This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
checkpoint: flush global checkpoint when first time flush checkpoint #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
status/PTAL
This PR is ready for review. Add this label back after committing new changes
type/bug-fix
Bug fix
labels
Jun 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
================================================
+ Coverage 57.0981% 57.1629% +0.0647%
================================================
Files 205 206 +1
Lines 21104 21311 +207
================================================
+ Hits 12050 12182 +132
- Misses 7890 7940 +50
- Partials 1164 1189 +25 |
GMHDBJD
requested review from
WangXiangUSTC and
csuzhangxc
and removed request for
WangXiangUSTC
June 23, 2020 10:40
GMHDBJD
changed the title
checkpoint: flush global checkpoint when first flush checkpoint
checkpoint: flush global checkpoint when first time flush checkpoint
Jun 23, 2020
csuzhangxc
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we need to cherry-pick this to release-1.0
?
rest LGTM
GMHDBJD
added
the
needs-cherry-pick-release-1.0
This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0
label
Jun 24, 2020
@WangXiangUSTC @csuzhangxc PTAL again ~ |
csuzhangxc
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Jun 24, 2020
/run-all-tests |
WangXiangUSTC
approved these changes
Jun 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WangXiangUSTC
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Jun 28, 2020
cherry pick to release-1.0 failed |
lance6716
removed
the
needs-cherry-pick-release-1.0
This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0
label
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #757
What is changed and how it works?
flush global checkpoint when first flush checkpoint
Check List
Tests