Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

error_message: fix misleading error message for pt online-ddl-schem… #738

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 15, 2020

cherry pick 711 (#711)

What problem does this PR solve?

fix misleading error message for pt online-ddl-schema

Tests

  • Unit test
  • Integration test

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #738 into release-1.0 will increase coverage by 0.0253%.
The diff coverage is 34.7826%.

@@                 Coverage Diff                 @@
##           release-1.0       #738        +/-   ##
===================================================
+ Coverage      57.8399%   57.8653%   +0.0253%     
===================================================
  Files              166        166                
  Lines            16990      16986         -4     
===================================================
+ Hits              9827       9829         +2     
+ Misses            6207       6201         -6     
  Partials           956        956                

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport) labels Jun 15, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone Jun 15, 2020
@csuzhangxc csuzhangxc requested a review from WangXiangUSTC June 15, 2020 08:55
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 15, 2020
@GMHDBJD GMHDBJD merged commit 70bc875 into pingcap:release-1.0 Jun 15, 2020
@GMHDBJD GMHDBJD deleted the cherryPick711 branch June 15, 2020 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants