Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

error_message: fix misleading error message for pt online-ddl-scheme #711

Merged
merged 5 commits into from
Jun 15, 2020
Merged

error_message: fix misleading error message for pt online-ddl-scheme #711

merged 5 commits into from
Jun 15, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 4, 2020

What problem does this PR solve?

#702

What is changed and how it works?

change error instance name and error message

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Jun 4, 2020
csuzhangxc
csuzhangxc reviewed Jun 4, 2020
View reviewed changes
pkg/terror/error_list.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/terror/error_list.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 5, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone Jun 5, 2020
@csuzhangxc
Copy link
Member

/run-all-tests

WangXiangUSTC
WangXiangUSTC reviewed Jun 11, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

_utils/terror_gen/errors_release.txt Outdated Show resolved Hide resolved
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jun 15, 2020

/run-all-tests

1 similar comment
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jun 15, 2020

/run-all-tests

WangXiangUSTC
WangXiangUSTC approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 15, 2020
@csuzhangxc csuzhangxc merged commit 2c8f4a6 into pingcap:master Jun 15, 2020
@ti-srebot
Copy link

cherry pick to release-1.0 failed

@csuzhangxc
Copy link
Member

@GMHDBJD please cherry-pick it manually.

GMHDBJD added a commit to GMHDBJD/dm that referenced this pull request Jun 15, 2020
@GMHDBJD
error_message: fix misleading error message for pt online-ddl-scheme (
e766a8a 
pingcap#711)
@GMHDBJD GMHDBJD mentioned this pull request Jun 15, 2020
Merged
@csuzhangxc csuzhangxc added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Jun 15, 2020
GMHDBJD added a commit that referenced this pull request Jun 15, 2020
@GMHDBJD
error_message: fix misleading error message for pt online-ddl-scheme (
70bc875 
#711) (#738)
GMHDBJD added a commit that referenced this pull request Jul 15, 2020
@GMHDBJD
error_message: more friendly error message #711 (#799)
becb317
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v1.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @csuzhangxc @ti-srebot @WangXiangUSTC