Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: reset some metrics when loader resume (#558) #570

Merged
merged 2 commits into from
Mar 23, 2020
Merged

fix: reset some metrics when loader resume (#558) #570

merged 2 commits into from
Mar 23, 2020

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Mar 23, 2020

cherry-pick #558 to release-1.0

What problem does this PR solve?

fix #459

What is changed and how it works?

  • modify this metrics to gaugeVec:
    • dataFileCountor => dataFileGauge
    • tableCountor => tableGauge
    • dataSizeCountor => dataSizeGauge
  • modify dm/dm-ansible/scripts/dm.json related PromQL expressions
  • modify related code for metrics

@sre-bot sre-bot added contribution For contributor priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 23, 2020
@sre-bot sre-bot mentioned this pull request Mar 23, 2020
Merged
@sre-bot sre-bot requested review from csuzhangxc and lichunzhu March 23, 2020 09:16
csuzhangxc
csuzhangxc reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 23, 2020 •
edited
Loading

Codecov Report

Merging #570 into release-1.0 will decrease coverage by 0.0017%.
The diff coverage is 0%.

@@                 Coverage Diff                 @@
##           release-1.0       #570        +/-   ##
===================================================
- Coverage      57.2774%   57.2756%   -0.0018%     
===================================================
  Files              161        161                
  Lines            16668      16672         +4     
===================================================
+ Hits              9547       9549         +2     
- Misses            6178       6181         +3     
+ Partials           943        942         -1

lichunzhu
lichunzhu approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit 8e122b5 into pingcap:release-1.0 Mar 23, 2020
@csuzhangxc csuzhangxc added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Apr 23, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated contribution For contributor priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @csuzhangxc @lichunzhu @Kuri-su