Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: reset some metrics when loader resume #558

Merged
merged 3 commits into from
Mar 23, 2020
Merged

fix: reset some metrics when loader resume #558

merged 3 commits into from
Mar 23, 2020

Conversation

Kuri-su
Copy link
Contributor

@Kuri-su Kuri-su commented Mar 19, 2020 •
edited by csuzhangxc
Loading

UCP #459

What problem does this PR solve?

fix #459

What is changed and how it works?

  • modify this metrics to gaugeVec:
    • dataFileCountor => dataFileGauge
    • tableCountor => tableGauge
    • dataSizeCountor => dataSizeGauge
  • modify dm/dm-ansible/scripts/dm.json related PromQL expressions
  • modify related code for metrics

@sre-bot sre-bot added the contribution For contributor label Mar 19, 2020
@Kuri-su Kuri-su changed the title fix: kurisu reset some metrics when loader restart fix: kurisu reset some metrics when loader resume Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9724aa0). Click here to learn what that means.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master       #558   +/-   ##
===========================================
  Coverage          ?   56.6481%           
===========================================
  Files             ?        186           
  Lines             ?      19088           
  Branches          ?          0           
===========================================
  Hits              ?      10813           
  Misses            ?       7178           
  Partials          ?       1097

@Kuri-su Kuri-su changed the title fix: kurisu reset some metrics when loader resume fix: reset some metrics when loader resume Mar 20, 2020
@Kuri-su
Copy link
Contributor Author

Kuri-su commented Mar 23, 2020

@csuzhangxc PTAL, thx 😂

@csuzhangxc
Copy link
Member

@Kuri-su I'll take a look later today. 😂

@csuzhangxc csuzhangxc added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Mar 23, 2020
csuzhangxc
csuzhangxc reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 23, 2020
@csuzhangxc
Copy link
Member

@lichunzhu PTAL

lichunzhu
lichunzhu approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

@Kuri-su please update branch and run the tests

@csuzhangxc csuzhangxc merged commit 0f79c01 into pingcap:master Mar 23, 2020
@sre-bot sre-bot mentioned this pull request Mar 23, 2020
Merged
@sre-bot
Copy link

sre-bot commented Mar 23, 2020

cherry pick to release-1.0 in PR #570

@sre-bot sre-bot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Mar 23, 2020
@csuzhangxc
Copy link
Member

/award-point 200

@Kuri-su
Copy link
Contributor Author

Kuri-su commented Mar 23, 2020

/award-point 200

thank you 😜

@you06
Copy link

you06 commented Mar 23, 2020

The score issue has been fixed.

@csuzhangxc
Copy link
Member

The score issue has been fixed.

thanks

@you06
Copy link

you06 commented Mar 23, 2020

@Kuri-su You can check it out at https://pingcap.com/community-cn/tidb-usability-challenge/

@Kuri-su
Copy link
Contributor Author

Kuri-su commented Mar 23, 2020

@Kuri-su You can check it out at https://pingcap.com/community-cn/tidb-usability-challenge/

got it

lichunzhu pushed a commit that referenced this pull request Mar 23, 2020
@sre-bot
fix: reset some metrics when loader resume (#558) (#570)
8e122b5
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@Kuri-su
fix: reset some metrics when loader resume (pingcap#558)
af8dbf4
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@Kuri-su @lichunzhu
fix: reset some metrics when loader resume (pingcap#558)
2e4f070
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 7, 2020
@Kuri-su @lichunzhu
fix: reset some metrics when loader resume (pingcap#558)
e743c0f
@Kuri-su Kuri-su deleted the feature/kurisu-reset-some-metrics-when-loader-restart-200319 branch April 7, 2020 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked contribution For contributor priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UCP: reset some metrics of load unit when resuming
5 participants
@Kuri-su @csuzhangxc @lichunzhu @sre-bot @you06