Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

utils: fix value out of range for getting server_id (#537) #538

Merged
merged 1 commit into from
Mar 13, 2020
Merged

utils: fix value out of range for getting server_id (#537) #538

merged 1 commit into from
Mar 13, 2020

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Mar 13, 2020

cherry-pick #537 to release-1.0

What problem does this PR solve?

fix #536

What is changed and how it works?

use strconv.ParseUint instead of strconv.ParseInt to parse server_id.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@sre-bot sre-bot mentioned this pull request Mar 13, 2020
Merged
@sre-bot sre-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 13, 2020
@sre-bot sre-bot requested a review from lichunzhu March 13, 2020 06:36
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@csuzhangxc csuzhangxc added this to the v1.0.4 milestone Mar 13, 2020
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@csuzhangxc
Copy link
Member

@lichunzhu @WangXiangUSTC PTAL

lichunzhu
lichunzhu reviewed Mar 13, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 13, 2020
csuzhangxc
csuzhangxc approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Mar 13, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #538 into release-1.0 will increase coverage by 0.024%.
The diff coverage is 100%.

@@                Coverage Diff                 @@
##           release-1.0       #538       +/-   ##
==================================================
+ Coverage      57.2775%   57.3015%   +0.024%     
==================================================
  Files              161        161               
  Lines            16654      16654               
==================================================
+ Hits              9539       9543        +4     
+ Misses            6173       6168        -5     
- Partials           942        943        +1

@csuzhangxc csuzhangxc merged commit ac0554c into pingcap:release-1.0 Mar 13, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @csuzhangxc @lichunzhu