Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

utils: fix value out of range for getting server_id #537

Merged
merged 1 commit into from
Mar 13, 2020
Merged

utils: fix value out of range for getting server_id #537

merged 1 commit into from
Mar 13, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

fix #536

What is changed and how it works?

use strconv.ParseUint instead of strconv.ParseInt to parse server_id.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer labels Mar 13, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @lichunzhu PTAL

@csuzhangxc csuzhangxc added this to the v1.0.4 milestone Mar 13, 2020
@WangXiangUSTC
Copy link
Contributor

LGTM

lichunzhu
lichunzhu approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit 56eed52 into pingcap:master Mar 13, 2020
@csuzhangxc csuzhangxc deleted the fix-server-id branch March 13, 2020 06:36
@sre-bot sre-bot mentioned this pull request Mar 13, 2020
Merged
@sre-bot
Copy link

sre-bot commented Mar 13, 2020

cherry pick to release-1.0 in PR #538

@sre-bot sre-bot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Mar 13, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 13, 2020
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc
utils: fix value out of range for getting server_id (pingcap#537)
3d17a9b
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc @lichunzhu
utils: fix value out of range for getting server_id (pingcap#537)
9133218
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 7, 2020
@csuzhangxc @lichunzhu
utils: fix value out of range for getting server_id (pingcap#537)
a38e8ff
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix
Projects
None yet
Milestone
v1.0.4
Development

Successfully merging this pull request may close these issues.

invalid server id *: strconv.ParseInt: parsing "*": value out of range
4 participants
@csuzhangxc @WangXiangUSTC @sre-bot @lichunzhu