Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker: use random value as server-id if server-id is not set (#329) #337

Merged
merged 1 commit into from
Oct 28, 2019
Merged

worker: use random value as server-id if server-id is not set (#329) #337

merged 1 commit into from
Oct 28, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Oct 28, 2019 •
edited by lichunzhu
Loading

cherry pick from #329

What problem does this PR solve?

use random value as server-id if server-id is not set

What is changed and how it works?

if server id is not set, generate a random value for it

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@WangXiangUSTC WangXiangUSTC added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 28, 2019
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

lichunzhu
lichunzhu reviewed Oct 28, 2019
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@5f3fedc). Click here to learn what that means.
The diff coverage is 48.9583%.

@@               Coverage Diff                @@
##             release-1.0       #337   +/-   ##
================================================
  Coverage               ?   59.9617%           
================================================
  Files                  ?        135           
  Lines                  ?      15158           
  Branches               ?          0           
================================================
  Hits                   ?       9089           
  Misses                 ?       5175           
  Partials               ?        894

csuzhangxc
csuzhangxc approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 28, 2019
@WangXiangUSTC WangXiangUSTC merged commit 1641c68 into release-1.0 Oct 28, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/pick_server_id branch October 28, 2019 03:37
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WangXiangUSTC @csuzhangxc @lichunzhu