This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
worker: use random value as server-id if server-id is not set #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangXiangUSTC
added
needs-cherry-pick-release-1.0
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
================================================
- Coverage 59.9403% 59.9221% -0.0183%
================================================
Files 135 135
Lines 15090 15158 +68
================================================
+ Hits 9045 9083 +38
- Misses 5166 5182 +16
- Partials 879 893 +14 |
csuzhangxc
reviewed
Oct 22, 2019
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
csuzhangxc
reviewed
Oct 22, 2019
Co-Authored-By: Xuecheng Zhang <[email protected]>
csuzhangxc
reviewed
Oct 22, 2019
|
@csuzhangxc all addressed, PTAL again |
csuzhangxc
reviewed
Oct 22, 2019
csuzhangxc
reviewed
Oct 24, 2019
dm/worker/config.go
Outdated
| c.Flavor, err = utils.GetFlavor(ctx, fromDB.DB) | ||
| if ctx.Err() != nil { | ||
| err = terror.Annotatef(err, "time cost to get flavor info exceeds %s", flavorGetTimeout) | ||
| rand.Seed(time.Now().UnixNano()) |
There was a problem hiding this comment.
can we do this when starting the process?
There was a problem hiding this comment.
address comment b1a8fbd
lichunzhu
reviewed
Oct 24, 2019
dm/worker/config.go
Outdated
| rand.Seed(time.Now().UnixNano()) | ||
| for i := 0; i < 5; i++ { | ||
| randomValue := uint32(rand.Intn(100000)) | ||
| randomServerID := maxServerID/10 + randomValue |
There was a problem hiding this comment.
It sames that the only use of maxServerID is maxServerID/10. How about set maxServerID directly to math.MaxUint32/10?
There was a problem hiding this comment.
update 354a2fc
There was a problem hiding this comment.
What about storing math.MaxUint32/10 into a variable so that we don't need to compute it every time?
|
@csuzhangxc @lichunzhu PTAL again |
csuzhangxc
added
status/LGT1
lichunzhu
added
status/LGT2
|
/run-all-tests |
|
cherry pick to release-1.0 failed |
|
@WangXiangUSTC Please cherry-pick to release-1.0 manually. |
WangXiangUSTC
added a commit
that referenced
this pull request
Oct 28, 2019
WangXiangUSTC
added
already-cherry-pick-1.0
WangXiangUSTC
added a commit
that referenced
this pull request
Oct 28, 2019
csuzhangxc
added
already-update-release-note
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
use random value as server-id if server-id is not set
What is changed and how it works?
if server id is not set, generate a random value for it
Check List
Tests
Related changes