Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dep: check some privilege should be globally granted #1366

Merged
merged 4 commits into from
Jan 11, 2021
Merged

dep: check some privilege should be globally granted #1366

merged 4 commits into from
Jan 11, 2021

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

close #1320

What is changed and how it works?

tidb-tools should have fix it

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jan 6, 2021
@lance6716

This comment has been minimized.

Sign in to view
@lance6716 lance6716 added the status/DNM Do not merge, test is failing or blocked by another PR label Jan 7, 2021
@lance6716 lance6716 removed the status/DNM Do not merge, test is failing or blocked by another PR label Jan 8, 2021
GMHDBJD
GMHDBJD approved these changes Jan 11, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added the status/LGT1 One reviewer already commented LGTM label Jan 11, 2021
@lance6716 lance6716 merged commit 49223f3 into pingcap:master Jan 11, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Jan 11, 2021
@lance6716 @ti-srebot
cherry pick pingcap#1366 to release-2.0
8397bb8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 11, 2021
Closed
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1371

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jan 11, 2021
This was referenced Jan 12, 2021
Merged
Merged
@ti-srebot ti-srebot mentioned this pull request Jan 12, 2021
Closed
@lance6716 lance6716 mentioned this pull request Jan 12, 2021
Merged
@lance6716 lance6716 added this to the v2.0.2 milestone Jan 13, 2021
lance6716 added a commit that referenced this pull request Jan 13, 2021
@lance6716
dep: check some privilege should be globally granted (#1366) (#1375)
924cd2b
@lance6716 lance6716 deleted the update-dep-2 branch May 20, 2021 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT1 One reviewer already commented LGTM
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.

precheck didn't work so dumpling created illegal metadata
3 participants
@lance6716 @ti-srebot @GMHDBJD