Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

feat: source level filter support #1370

Merged
merged 8 commits into from
Jan 25, 2021
Merged

feat: source level filter support #1370

merged 8 commits into from
Jan 25, 2021

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jan 11, 2021

What problem does this PR solve?

close #1264

What is changed and how it works?

add binlog filter config in source configuartion file.

Check List

Tests

  • Integration test

@GMHDBJD GMHDBJD added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jan 11, 2021
@GMHDBJD GMHDBJD added this to the v2.0.2 milestone Jan 11, 2021
@GMHDBJD GMHDBJD added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Jan 11, 2021
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jan 11, 2021

/run-all-tests

1 similar comment
@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716

This comment has been minimized.

Sign in to view
lance6716
lance6716 reviewed Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/worker/worker.go Show resolved Hide resolved
@lance6716
Copy link
Collaborator

/lgtm

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Jan 18, 2021
@lance6716 lance6716 merged commit 7cc727f into pingcap:master Jan 25, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Jan 25, 2021
@GMHDBJD @ti-srebot
cherry pick pingcap#1370 to release-2.0
40fc66e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 25, 2021
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1399

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jan 25, 2021
lance6716 pushed a commit that referenced this pull request Jan 25, 2021
@ti-srebot
cherry pick #1370 to release-2.0 (#1399)
ed4297c
@lance6716 lance6716 mentioned this pull request Feb 22, 2021
Merged
7 tasks
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 left review comments

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.

source level filter support
4 participants
@GMHDBJD @lance6716 @ti-srebot @zier-one