Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

utils: support OVER_MAX_DBS_IN_EVENT_MTS (254) in binlog #1298

Merged
merged 1 commit into from
Nov 25, 2020
Merged

utils: support OVER_MAX_DBS_IN_EVENT_MTS (254) in binlog #1298

merged 1 commit into from
Nov 25, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

close #1275

What is changed and how it works?

handle OVER_MAX_DBS_IN_EVENT_MTS separately

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix priority/unimportant Really minor change, requires approval from secondary reviewers labels Nov 25, 2020
@lance6716 lance6716 added this to the v2.0.1 milestone Nov 25, 2020
csuzhangxc
csuzhangxc reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Nov 25, 2020
GMHDBJD
GMHDBJD approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Nov 25, 2020
@lance6716 lance6716 merged commit ff064e8 into pingcap:master Nov 25, 2020
@lance6716 lance6716 deleted the fix-dbnames branch November 25, 2020 08:12
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Nov 25, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1298 to release-2.0
faab7fc 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1299

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Nov 25, 2020
lance6716 pushed a commit that referenced this pull request Nov 25, 2020
@ti-srebot
cherry pick #1298 to release-2.0 (#1299)
26c2078
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.

found error when get sql_mode from binlog status_vars
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD