cherry pick #1298 to release-2.0 (#1299)

pingcap · Nov 25, 2020 · 26c2078 · 26c2078
1 parent 13191a8
commit 26c2078
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/pkg/binlog/event/util.go b/pkg/binlog/event/util.go
@@ -442,6 +442,11 @@ func statusVarsToKV(statusVars []byte) (map[byte][]byte, error) {
 				return generateError(err)
 			}
 			value = append(value, count)
+			// if count is 254 (OVER_MAX_DBS_IN_EVENT_MTS), there's no following DB names
+			// https://github.com/mysql/mysql-server/blob/ee4455a33b10f1b1886044322e4893f587b319ed/libbinlogevents/include/binlog_event.h#L107
+			if count == 254 {
+				break
+			}
 
 			buf := make([]byte, 0, 128)
 			b := byte(1) // initialize to any non-zero value

diff --git a/pkg/binlog/event/util_test.go b/pkg/binlog/event/util_test.go
@@ -78,6 +78,18 @@ func (t *testUtilSuite) TestStatusVarsToKV(c *C) {
 			},
 			nil,
 		},
+		// OVER_MAX_DBS_IN_EVENT_MTS in Q_UPDATED_DB_NAMES
+		{
+			[]byte{0, 0, 0, 0, 0, 1, 0, 0, 160, 85, 0, 0, 0, 0, 6, 3, 115, 116, 100, 4, 45, 0, 45, 0, 33, 0, 12, 254},
+			map[byte][]byte{
+				0:  {0, 0, 0, 0},
+				1:  {0, 0, 160, 85, 0, 0, 0, 0},
+				6:  {3, 115, 116, 100},
+				4:  {45, 0, 45, 0, 33, 0},
+				12: {254},
+			},
+			nil,
+		},
 	}
 
 	for _, t := range testCases {