Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

performance: use OPTIMISTIC transaction as the default (#1079) #1107

Merged
merged 19 commits into from
Sep 27, 2020
Merged

performance: use OPTIMISTIC transaction as the default (#1079) #1107

merged 19 commits into from
Sep 27, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1079 to release-2.0

What problem does this PR solve?

close #751

What is changed and how it works?

set default transaction mode to optimistic

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    verify with different session cfg and run show variables

@ti-srebot ti-srebot mentioned this pull request Sep 27, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 27, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 27, 2020
csuzhangxc
csuzhangxc approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated and removed status/LGT1 One reviewer already commented LGTM labels Sep 27, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 27, 2020
@csuzhangxc csuzhangxc merged commit a220d84 into pingcap:release-2.0 Sep 27, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lance6716 @csuzhangxc @GMHDBJD