This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
performance: use OPTIMISTIC transaction as the default #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
priority/normal
|
LGTM |
csuzhangxc
reviewed
Sep 24, 2020
dm/config/task.go
Outdated
|
|
||
| // TargetDBConfig | ||
| defaultSessionCfg = map[string]string{ | ||
| tidbTxnMode: tidbTxnOptimistic, |
There was a problem hiding this comment.
Does a lower version of TiDB without optimistic TXN works well (or without interrupt)?
GMHDBJD
added
status/WIP
|
/run-all-tests |
This reverts commit 614def3.
|
/run-all-tests |
GMHDBJD
added
status/PTAL
|
LGTM |
csuzhangxc
reviewed
Sep 27, 2020
| cfgs[i] = cfg | ||
| } | ||
| return cfgs, nil | ||
| } | ||
|
|
||
| func adjustTargetDB(ctx context.Context, dbConfig *config.DBConfig) error { |
There was a problem hiding this comment.
How about putting this function into task.go as a member of TaskConfig? we may need to use it in other places later.
There was a problem hiding this comment.
circle import if move it to task.go because we import config in pkg.conn. 🤔
csuzhangxc
added
status/LGT2
|
cherry pick to release-2.0 in PR #1107 |
ti-srebot
added
already-cherry-pick-2.0
csuzhangxc
pushed a commit
that referenced
this pull request
Sep 27, 2020
Co-authored-by: gmhdbjd <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #751
What is changed and how it works?
set default transaction mode to optimistic
Check List
Tests
verify with different session cfg and run
show variables