Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when encountering InvalidStatement #821

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Throw error when encountering InvalidStatement #821

wants to merge 2 commits into from

Conversation

tp
Copy link

@tp tp commented Apr 2, 2024

Fixes #820

@tp tp force-pushed the invalid-statement-handling branch from df5cf4e to 8040e0f Compare April 2, 2024 15:45
@tp
Copy link
Author

tp commented Apr 8, 2024

@stephanmantel Does this look good to you?

stephanmantel
stephanmantel previously approved these changes May 8, 2024
View reviewed changes
@stephanmantel
Copy link
Contributor

Yes, looks good to me, can you solve the conflicts?

@tp tp force-pushed the invalid-statement-handling branch from 8040e0f to 786aea4 Compare May 8, 2024 12:47
@tp
Copy link
Author

tp commented May 8, 2024

@stephanmantel Rebased on the develop branch here.

@tp tp requested a review from stephanmantel May 8, 2024 12:49
@tp
Copy link
Author

tp commented Jun 20, 2024

@stephanmantel Anything I can further help with to move this one forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanmantel stephanmantel stephanmantel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid query (failing to parse) does not throw an error
2 participants
@tp @stephanmantel