Throw error when encountering InvalidStatement

Fixes #820
pinchbv · May 8, 2024 · 786aea4 · 786aea4
1 parent e500e47
commit 786aea4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/floor_common/lib/src/adapter/query_adapter.dart b/floor_common/lib/src/adapter/query_adapter.dart
@@ -150,6 +150,11 @@ class QueryAdapter {
     } else if (rootNode is DeleteStatement) {
       result = await _database.rawDelete(sql, arguments).then(_mapResult);
       tableName = rootNode.table.tableName;
+    } else if (rootNode is InvalidStatement) {
+      // The underlying error is not contained in the node, so in order to find the root cause one needs to run with the debugger stopping on "all exceptions"
+      throw Exception('Failed to parse "$sql"');
+    } else {
+      throw Exception('Unknown statement type: $rootNode');
     }
 
     _notifyIfChanged(tableName, result);

diff --git a/floor_common/test/adapter/query_adapter_test.dart b/floor_common/test/adapter/query_adapter_test.dart
@@ -76,6 +76,12 @@ void main() {
         expect(actual, throwsStateError);
         verify(mockDatabaseExecutor.rawQuery(sql));
       });
+
+      test('exception because query can not be parsed', () async {
+        final deleteQueryFuture = underTest.queryNoReturn('DELETE * FROM foo');
+
+        expect(deleteQueryFuture, throwsA(isA<Exception>().having((e) => e.toString(), 'message', contains('Failed to parse'))));
+      });
     });
 
     group('query list', () {