Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer issues #815

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Analyzer issues #815

merged 1 commit into from
Mar 19, 2024

Conversation

dkaera
Copy link
Collaborator

@dkaera dkaera commented Mar 16, 2024

I'm submitting a PR on GitHub that contains crucial updates for addressing code analysis issues. It also introduces analysis options to the example project, which flags a warning when accessing the private _$...DatabaseBuilder. To resolve this, I've added an interface and accompanying tests to cover these updates. These changes are vital for fixing the problems that are currently hindering web integration support. I've tested the PR with my adjustments, and everything is working well. Merging this PR will unblock the web_support PR #730

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (a618e06) to head (f2a954f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #815   +/-   ##
========================================
  Coverage    91.92%   91.92%           
========================================
  Files           11       11           
  Lines          223      223           
========================================
  Hits           205      205           
  Misses          18       18           
Flag Coverage Δ
floor 91.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkaera dkaera force-pushed the feature/analyzer_issues branch from 9a00106 to f2a954f Compare March 16, 2024 22:32
@dkaera dkaera mentioned this pull request Mar 16, 2024
@dkaera dkaera merged commit 5658ea0 into pinchbv:develop Mar 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants