feat: Web support

[mirland]

Right now sqflite_common_ffi_web is in an experimental state, but if we add the factory, we can support the web optionally.

What do you think?

Currently, floor doesn't support web and we cannot update the factory creator, so if we want to support web we have to change the generated code (or duplicate code), and it's not a good idea.
This pr adds the web factory

[dkaera]

wow, looks good, did you test it out?

[mirland]

Yes doing these changes manually I could make my application work. I tested in this branch, but I did floor changes just locally

[dkaera]

Yes doing these changes manually I could make my application work. I tested in this branch, but I did floor changes just locally

awesome, I'll prepare the project update PR, because the current one contains a lot of changes in the .lock file, which doesn't related to the main change.

[dkaera]

Hey @mirland
ubuntu job has broken
I fixed it in my PR
let's merge your changes after mine

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (5658ea0) to head (aa095b6).

❗ Current head aa095b6 differs from pull request most recent head 9c19ecb. Consider uploading reports for the commit 9c19ecb to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #730       +/-   ##
==========================================
- Coverage    91.92%      0   -91.93%     
==========================================
  Files           11      0       -11     
  Lines          223      0      -223     
==========================================
- Hits           205      0      -205     
+ Misses          18      0       -18     

Flag	Coverage Δ
floor	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mirland]

Hi @dkaera, do you have any feedback for my PR? I don't know if I can do something to merge it

[dkaera]

Hi @dkaera, do you have any feedback for my PR? I don't know if I can do something to merge it

the coverage check blocks this PR, so you need to add the corresponding test for the newly added condition first

[mirland]

the coverage check blocks this PR, so you need to add the corresponding test for the newly added condition first

Hi @dkaera , can you suggest to me how can I do that, in this case, there's no test to do, I mean, if we want to do that we should like mock the platform and check the factory. I checked your tests and that method seems to be not tested and there's not something similar

[mirland]

@dkaera can you suggest to me what kind of test should I include?

[dkaera]

@dkaera can you suggest to me what kind of test should I include?

ah, I'm sorry, I can't help you now, because of the heavy workload.

[mirland]

Ok, np, no rush. Then when you have time, please check it because I changed only 3 lines and I think I cannot do a test for that.

Thanks!

[dkaera]

Ok, np, no rush. Then when you have time, please check it because I changed only 3 lines and I think I cannot do a test for that.

Thanks!

I think we can mock Platform value and verify what the instance was factory created.

[stefanosiano]

any news on this?
No rush, i'd just like to try floor instead of sqflite in my project, which runs on desktop and web

[mirland]

Hey, not really, I couldn't do the test. I mean, If I wanted to add it I had to redefine some things, and I didn't find the value of that only for this test. However, if you want to try the database on the web it's not had. You have to add the dependency, and then redefine the factory in your app database.

Here you have an example: https://github.com/xmartlabs/fluttips/blob/main/lib/core/source/database.dart#L24

After that you have to set up the binaries, and that's all

[stephanmantel]

Ok, np, no rush. Then when you have time, please check it because I changed only 3 lines and I think I cannot do a test for that.

Thanks!

I think we can mock Platform value and verify what the instance was factory created.

Is it possible to mock Platform and kIsWeb? I found no support for static mocking using Mockito.

We could also resort to a wrapper object, but I feel like that misses the point a bit, as the real logic you'd want to test is mocked away. What do you guys think, is it necessary to test this?

[dkaera]

Hey guys
PR #815 should resolve the analyzer issues and unlock the merge of the current PR
Lets push it to development brunch then we can merge @mirland changes to support web
I tested it locally - everything works fine 💪💪💪

[stephanmantel]

Hey guys PR #815 should resolve the analyzer issues and unlock the merge of the current PR Lets push it to development brunch then we can merge @mirland changes to support web I tested it locally - everything works fine 💪💪💪

I love it, let's get it merged and great idea to have brunch ;)

[hendrikvdkaaden]

Is this PR still relevant, since it's merged to #819?

[dkaera]

@hendrikvdkaaden yes we can close this PR

[dkaera]

the changes were picked up and integrated separately