Implement document deletion #17
Conversation
|
I didn't realize I'd need to do testing for coveralls. I'll take a look at that and update. |
…leting a document.
…leting a document.
…leting a document.
| @@ -273,6 +273,9 @@ class DocumentDelete(LoginRequiredMixin, DeleteView): | |||
| model = Document | |||
| success_url = reverse_lazy("pinax_documents:document_index") | |||
|
|
|||
| def get_template_names(self): | |||
There was a problem hiding this comment.
@ethankent Can we just specify the the template_name on the class directly?
There was a problem hiding this comment.
Hi @paltman
Thanks for the update. Just wanted to clarify your question a bit. I think you're asking if the template name can be specified in the same way that template_name is specified in the DocumentDetail class. The answer is yes!
For some reason I was thinking that the template name needed to be calculated dynamically (for instance showing a different template for post() than for get()). I suppose if we wanted to show a confirmation message that might be a good way to go. But we don't, we want to redirect upon successful deletion. So, specifying the static class variable template_name seems like a no-brainer now. Thanks for the feedback on that. I'll update right away.
|
@ethankent looks great. Be merged your PR on the theme and left a comment about one small thing I'd like to see fixed. |
…succinct *template_name* class variable.
Related to this issue - #3