Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement document deletion #3

Closed
jacobwegner opened this issue Dec 17, 2015 · 3 comments
Closed

Implement document deletion #3

jacobwegner opened this issue Dec 17, 2015 · 3 comments
Labels
bug enhancement
Milestone
16.04

Comments

@jacobwegner
Copy link

The document_delete view doesn't actually delete the Document model.

In addition, I think it is reasonable to remove the file from disk/project's storage backend, probably implemented with a pre_delete signal.
@paltman paltman mentioned this issue Feb 5, 2016
Closed
@paltman paltman modified the milestone: 16.04 Mar 18, 2016
This was referenced Mar 30, 2016
Merged
Merged
@ethankent
Copy link
Contributor

Hi,

I have a pull request out for this: #17, but it's failing because it requires another pull request: pinax/pinax-theme-bootstrap#115

@paltman paltman modified the milestones: 16.04, Documents Starter Project: Milestone 0 Mar 31, 2016
@ethankent
Copy link
Contributor

Looks like everything is up-to-date now. Thanks for your help. I think we could probably even close off this issue and check it off the Milestone List: https://github.com/pinax/pinax-starter-projects/wiki/Groupware-Starter-Project

@paltman paltman closed this as completed Apr 1, 2016
@paltman
Copy link
Member

paltman commented Apr 1, 2016

@ethankent Awesome! Just one more left for pinax-documents. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
16.04
Development

No branches or pull requests
4 participants
@paltman @jacobwegner @ossanna16 @ethankent