-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of R #13
Comments
Thanks Jonathan. You are absoluterly right regarging the use of Scipy+Matplotlib versus R. This is even more true when you see the beautiful figures we can obtain with Matplotlib http://www.ploscompbiol.org/article/info%3Adoi%2F10.1371%2Fjournal.pcbi.1003833 Unfortunately, I don't know how to use both Matplolib and Scipy. If you have some time I would be more than happy to merge your contributions. |
I am a bit busy right now but I'll have a look. It should not be very difficult to do. |
I agree. I'll published a dev branch as soon as I make something interesting. |
I am looking at the clustering. I'll try to send a pull request as soon as possible. |
One question is -i'm playing devil's advocate- that Scipy+Matplotlib also evolve. R seems quite stable, is it the same thing for both ? |
On 22/04/15 10:20, Alexandre G. de Brevern wrote:
There are two main points at getting rid of R:
Removing R is some work. But it is not an awful lot either. It may not |
I agree with @jbarnoud. |
|
So, where are we now ?? |
The only remaining dependancy to R is the clustering that we will revamp anyway. I set this issue as a duplicate of #64 and close it. |
PBxplore uses R to draw figures and to perform hierarchical clustering. This implies a heavy dependence to R;. It also requires to know two languages to maintain the software instead of one. Finally, as R is called via subprocess rather that via rpy, it requires to write intermediate scripts which is error prone and difficult to maintain.
All the thing done with R could be done in python.
Figures could be drawn using the matplotlib library. This would imply a dependence to the matplotlib python package, yet depending on a python package is lighter in a python environment than depending on an external interpreter. Also, the python scientific stack is already required through the numpy package.
Hierarchical clustering is available in the scipy module: http://docs.scipy.org/doc/scipy/reference/cluster.hierarchy.html. As matplotlib, scipy os part of the classical python scientific stack. Other python modules implement hierarchical clustering (see http://nbviewer.ipython.org/github/OxanaSachenkova/hclust-python/blob/master/hclust.ipynb and http://bioinformatics.org.au/tools/hclust/) but they would create dependencies to less classical python modules.
R is called in two files: PBstat.py and PBclust.py.
The text was updated successfully, but these errors were encountered: