Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak teleporter success message #2796

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Tweak teleporter success message #2796

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca0346a
Add hint that users should run pihole -g after successful teleporter …
DL6ER Oct 30, 2023
db3fcb4
Show extra info alert on successful import to remind users they shoul…
DL6ER Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/pi-hole/js/settings-teleporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ function importZIP() {
if (data.error.hint !== null) $("#modal-import-error-message").text(data.error.hint);
} else if ("files" in data) {
$("#modal-import-success").show();
$("#modal-import-success-title").text("Import successful");
$("#modal-import-success-title").text(
"Import successful, please run pihole -g to update gravity."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a hyperlink to the web interface's own gravity update page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just throwing ideas around:

Use a button or move the text+link from the alert title

View examples

image

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea to move the text to the bottom. The button alone does not indicate that users should run gravity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about...

Screenshot from 2023-11-03 18-50-46

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good.

);
var text = "<p>Processed files:<ul>";
for (var i = 0; i < data.files.length; i++) {
text += "<li>/" + utils.escapeHtml(data.files[i]) + "</li>";
Expand Down