Tweak teleporter success message #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import Signed-off-by: DL6ER <[email protected]>
yubiuser
previously approved these changes
Oct 30, 2023
PromoFaux
reviewed
Oct 30, 2023
| @@ -48,7 +48,9 @@ function importZIP() { | |||
| if (data.error.hint !== null) $("#modal-import-error-message").text(data.error.hint); | |||
| } else if ("files" in data) { | |||
| $("#modal-import-success").show(); | |||
| $("#modal-import-success-title").text("Import successful"); | |||
| $("#modal-import-success-title").text( | |||
| "Import successful, please run pihole -g to update gravity." | |||
There was a problem hiding this comment.
Maybe a hyperlink to the web interface's own gravity update page?
There was a problem hiding this comment.
Just throwing ideas around:
Use a button or move the text+link from the alert title
View examples
There was a problem hiding this comment.
I like the idea to move the text to the bottom. The button alone does not indicate that users should run gravity.
…d run gravity's update Signed-off-by: DL6ER <[email protected]>
yubiuser
approved these changes
Nov 3, 2023
rdwebdesign
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Address comment by @yubiuser at #2738 (review)
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.