Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOTP input field not being shown when enabled #2783

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 26, 2023

What does this implement/fix?

See title, the issue is that 401 Unauthorized is not handled in .done() but in .fail()

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team October 26, 2023 15:02
@DL6ER DL6ER mentioned this pull request Oct 26, 2023
@DL6ER DL6ER linked an issue Oct 26, 2023 that may be closed by this pull request
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation, there is no 401 but only 200 return code. Is this a flaw in the documentation?

Screenshot at 2023-10-26 23-42-42

@DL6ER
Copy link
Member Author

DL6ER commented Oct 27, 2023

Thanks, fixed by pi-hole/FTL#1700

@DL6ER DL6ER merged commit e669b99 into development-v6 Oct 30, 2023
7 checks passed
@DL6ER DL6ER deleted the fix/totp branch October 30, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2FA Does Not Work
2 participants