Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA Does Not Work #2779

Closed
NittanySeaLion opened this issue Oct 24, 2023 · 4 comments · Fixed by #2783
Closed

2FA Does Not Work #2779

NittanySeaLion opened this issue Oct 24, 2023 · 4 comments · Fixed by #2783

Comments

@NittanySeaLion
Copy link

As reported on Discourse (https://discourse.pi-hole.net/t/sso-option/65791/2?u=blockhead), after enabling 2FA, the login screen does not unhide the totp box and allow entry of 2FA code.

Forcing the totp box to appear does not solve problem.

Perhaps an issue in FTL auth.c ?

@DL6ER
Copy link
Member

DL6ER commented Oct 26, 2023

Thanks for your report.

Perhaps an issue in FTL auth.c ?

Not, this is a web-only issue. This is an error that was introduced by a rearranging of code where the correct behavior for enabled TOTP seems to not have been checked. This is fixed by PR #2783

Forcing the totp box to appear does not solve problem.

I could not reproduce this. When manually showing the input field (remove class hidden), TOTP login works for me even on the unfixed developmet-v6 branch.

@DL6ER DL6ER linked a pull request Oct 26, 2023 that will close this issue
5 tasks
@NittanySeaLion
Copy link
Author

I can't rule out user error ;) will check when pushed over the weekend

@NittanySeaLion
Copy link
Author

I tested the fix, and it works for me. Enabling 2FA allows box to show up. Entering pw and 2FA credentials permits access. Disabling 2FA removes box.

@NittanySeaLion
Copy link
Author

@DL6ER fixed with PR 2783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants