-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically run cargo update
in a workflow
#330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combined with disabling Dependabot for major version
updates
Just to clarify your typo: Dependabot is disabled for everything but major versions. So major versions will still automatically get separate PRs.
I much prefer this over the previous state of things, though one thing that surprises me is that dependabot doesn't have the option to do this on its own? I feel like it should be capable of creating one PR to just bump all the minor stuff without having to define a separate action for it?
You are correct... I wrote it backwards. I'll amend to correct it.
The feature was requested a full three years ago in dependabot/dependabot-core#2174, but there hasn't been much progress from what I can tell. |
This runs a basic `cargo update` in a Github Action and creates a PR with any changes. Combined with limiting Dependabot to major version updates, this should resolve concerns about too many PRs and being too strict in our Cargo.toml files. Ref: Discussion on #325
6e29df5
to
14679da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow name will need to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output behavior can be observed and tweaked later, if desired.
LGTM
This runs a basic
cargo update
in a Github Action and creates a PRwith any changes. Combined with limiting Dependabot to major version
updates, this should resolve concerns about too many PRs and being too
strict in our Cargo.toml files.
Ref: Discussion on #325