-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump open from 2.1.1 to 2.1.2 #325
Conversation
Is dependabot just going to open a separate PR for every dependency? |
Yes... Time will tell if this gets annoying... |
I mean for me personally, it already has. Initially thought it was just for breaking changes, but if this is going to be the case for every dependency that's going to be a bit much. And pointlessly so because there really shouldn't be any reason to separate each dependency update into a separate PR. Talking worst-case scenario, if the bot checks once a week and for some magical reason every dependency gets updated, that would be 260 PRs. Even though that's not going to happen picking a random number between 0-260 every week is not something that sounds enticing to me. |
There may be a way to do this if we can get Dependabot to look at
Dependabot limits itself to no more than 5 open PRs by default (and gives us full control to change that number). |
I've found the
The linked repo uses it for a different reason though. They simply object to modifying @dependabot squash and merge |
58c939d
to
0280bbe
Compare
Bumps [open](https://github.com/Byron/open-rs) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/Byron/open-rs/releases) - [Changelog](https://github.com/Byron/open-rs/blob/main/changelog.md) - [Commits](Byron/open-rs@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: open dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
0280bbe
to
ffe6cce
Compare
Dependabot should never be changing the
So it will just stop opening PRs when it reaches this limit? I'd be surprised if there's less than 5 version updates each week.
I really don't see how anyone would have a different opinion on this. It's really the only approach that makes sense to me. |
Dependabot tried to merge this PR, but received the following error from GitHub:
|
This runs a basic `cargo update` in a Github Action and creates a PR with any changes. Combined with disabling Dependabot for major version updates, this should resolve concerns about too many PRs and being too strict in our Cargo.toml files. Ref: Discussion on #325
This runs a basic `cargo update` in a Github Action and creates a PR with any changes. Combined with limiting Dependabot to major version updates, this should resolve concerns about too many PRs and being too strict in our Cargo.toml files. Ref: Discussion on #325
This runs a basic `cargo update` in a Github Action and creates a PR with any changes. Combined with limiting Dependabot to major version updates, this should resolve concerns about too many PRs and being too strict in our Cargo.toml files. Ref: Discussion on #325
Bumps open from 2.1.1 to 2.1.2.
Release notes
Sourced from open's releases.
Changelog
Sourced from open's changelog.
Commits
ee25446
Release open v2.1.245e0388
update changelog85f4dfd
haiku: add platform supportDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @kylewillmon.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)