Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sandbox exceptions for local pip installs #1351

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fix sandbox exceptions for local pip installs #1351

merged 3 commits into from
Feb 1, 2024

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Jan 31, 2024

This fixes lockfile generation with pip when it is installed in ~/.local/lib/python*/site-packages/pip.

It also fixes an issue where pyenv installed through the package manager wouldn't allow for lockfile generation.

Closes #1349.

@cd-work cd-work requested a review from a team as a code owner January 31, 2024 23:09
@cd-work cd-work requested a review from maxrake January 31, 2024 23:09
This fixes lockfile generation with pip when it is installed in
`~/.local/lib/python*/site-packages/pip`.

It also fixes an issue where `pyenv` installed through the package
manager wouldn't allow for lockfile generation.

Closes #1349.
maxrake
maxrake previously approved these changes Jan 31, 2024
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with local testing. LGTM.

Copy link
Contributor

@louislang louislang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxrake maxrake merged commit d794a51 into main Feb 1, 2024
14 checks passed
@maxrake maxrake deleted the fix_local_pip branch February 1, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow more valid pip sources
3 participants