-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more valid pip
sources
#1349
Labels
Comments
maxrake
added
enhancement
New feature or request
high priority
Should be handled immediately
labels
Jan 30, 2024
maxrake
changed the title
Allow for more valid
Allow more valid Jan 31, 2024
pip
locationspip
sources
@phylum-dev/user-components This should be treated as critical. It's blocking a customer, we need to unblock them asap! |
For personal reference:
|
cd-work
added a commit
that referenced
this issue
Jan 31, 2024
This fixes lockfile generation with pip when it is installed in `~/.local/lib/python*/site-packages/pip`. It also fixes an issue where `pyenv` installed through the package manager wouldn't allow for lockfile generation. Closes #1349.
cd-work
added a commit
that referenced
this issue
Jan 31, 2024
This fixes lockfile generation with pip when it is installed in `~/.local/lib/python*/site-packages/pip`. It also fixes an issue where `pyenv` installed through the package manager wouldn't allow for lockfile generation. Closes #1349.
maxrake
pushed a commit
that referenced
this issue
Feb 1, 2024
This fixes lockfile generation with pip when it is installed in `~/.local/lib/python*/site-packages/pip`. It also fixes an issue where `pyenv` installed through the package manager wouldn't allow for lockfile generation. Closes #1349.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Overview
It has been observed that users with their primary/active
python3
/pip
binary located in~/.local
are not able to perform lockfile generation on pip manifest files. This is a valid location forpip
to exist and should be supported. Updates to sandbox exceptions are likely needed.Additional Guidance
A workaround exists to bypass the sandbox with the
--skip-sandbox
option. However, this is not recommended unless the fully resolved set of dependencies are already known and trusted since arbitrary code execution is possible without the sandbox.Acceptance Criteria
pip
manifests succeeds when the primarypip
binary is located in~/.local
and no other instances ofpip
existpip
extension sandbox permissions are updated to matchThe text was updated successfully, but these errors were encountered: