Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run question helper in interactive mode #520

Merged
merged 2 commits into from
Jul 27, 2018
Merged

Only run question helper in interactive mode #520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b170d3
Only run question helper in interactive mode
veewee Jun 29, 2018
8291811
Omit default argument
Landerstraeten Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/Console/Command/ConfigureCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,16 @@ protected function buildConfiguration(InputInterface $input, OutputInterface $ou
$binDir = $helper->ask($input, $output, $question);

// Search tasks
$question = new ChoiceQuestion(
'Which tasks do you want to run?',
$this->getAvailableTasks($this->config),
[]
);
$question->setMultiselect(true);
$tasks = $helper->ask($input, $output, $question);
$tasks = [];
if ($input->isInteractive()) {
$question = new ChoiceQuestion(
'Which tasks do you want to run?',
$this->getAvailableTasks($this->config),
null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is null, we can omit it, no?

);
$question->setMultiselect(true);
$tasks = (array) $helper->ask($input, $output, $question);
}

// Build configuration
return [
Expand Down