Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run question helper in interactive mode #520

Merged

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Jun 29, 2018

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets #516

Fixes #516 by not running the tasks question in non-interactive mode.

@veewee veewee added the bug label Jun 29, 2018
@veewee veewee added this to the Version 0.14.2 milestone Jun 29, 2018
@veewee veewee requested a review from Landerstraeten June 29, 2018 11:45
$question = new ChoiceQuestion(
'Which tasks do you want to run?',
$this->getAvailableTasks($this->config),
null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is null, we can omit it, no?

@Landerstraeten Landerstraeten merged commit caa00ac into phpro:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings at installation
2 participants