[BUGFIX] Make links to special objects prefixable #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
force-pushed
the
bugfix/confval
branch
from
3f74d25 to
ea130b1
Compare
linawolf
added a commit
to TYPO3-Documentation/render-guides
that referenced
this pull request
Mar 18, 2024
phpDocumentor/guides#945 will take care of duplicates. :name: can then be used to set an individual anchor if there are duplicates phpDocumentor/guides#932 takes care of the missing link prefix
linawolf
added a commit
to TYPO3-Documentation/render-guides
that referenced
this pull request
Mar 18, 2024
phpDocumentor/guides#945 will take care of duplicates. :name: can then be used to set an individual anchor if there are duplicates phpDocumentor/guides#932 takes care of the missing link prefix
typo3-documentation-team
pushed a commit
to TYPO3-Documentation/t3docs-typo3-docs-theme
that referenced
this pull request
Mar 18, 2024
phpDocumentor/guides#945 will take care of duplicates. :name: can then be used to set an individual anchor if there are duplicates phpDocumentor/guides#932 takes care of the missing link prefix
jaapio
reviewed
Mar 19, 2024
If we have both an anchor like '.. _demo:' and a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-". Therefore, I introduce the possibility of prefixing links to distinguished linkable objects. related #924 releases: main, 1.0
linawolf
force-pushed
the
bugfix/confval
branch
from
ea130b1 to
59accac
Compare
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".
Therefore I introduces the possibility of prefixing links to destinguished linkable objects.
related #924
releases: main, 1.0