Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make confvals linkable again #924

Closed
linawolf opened this issue Mar 13, 2024 · 2 comments
Closed

Make confvals linkable again #924

linawolf opened this issue Mar 13, 2024 · 2 comments
Assignees
@linawolf
Labels
feature triage

Comments

@linawolf
Copy link
Contributor

Feature request

Make confvals linkable again
@brotkrueml
Copy link
Contributor

That also means, that a confval must be unique (to determine the link destination) and duplicate confval definitions must output a warning (like in Sphinx). This is currently not the case.

@linawolf
Copy link
Contributor Author

I am working on some idea

@linawolf linawolf self-assigned this Mar 14, 2024
linawolf added a commit that referenced this issue Mar 16, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
0083923 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore I introduces the possibility of prefixing links to destinguished linkable objects.

related #924

releases: main, 1.0
@linawolf linawolf mentioned this issue Mar 16, 2024
Merged
linawolf added a commit that referenced this issue Mar 17, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
ea130b1 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore I introduces the possibility of prefixing links to destinguished linkable objects.

related #924

releases: main, 1.0
linawolf added a commit that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
59accac 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related #924

releases: main, 1.0
linawolf added a commit that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
006cf4c 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related #924

releases: main, 1.0
linawolf added a commit that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
3ef4ee0 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related #924

releases: main, 1.0
phpdoc-bot pushed a commit that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
1f9a95a 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related #924

releases: main, 1.0
(cherry picked from commit 3ef4ee0)
phpdoc-bot pushed a commit to phpDocumentor/guides-core that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
19646f0 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related phpDocumentor/guides#924

releases: main, 1.0
phpdoc-bot pushed a commit to phpDocumentor/guides-restructured-text that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
25ce42e 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related phpDocumentor/guides#924

releases: main, 1.0
phpdoc-bot pushed a commit to phpDocumentor/guides-core that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
96200cd 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related phpDocumentor/guides#924

releases: main, 1.0
(cherry picked from commit 3ef4ee08b2049e485d6fb30beb85ee1cbbeb883d)
phpdoc-bot pushed a commit to phpDocumentor/guides-restructured-text that referenced this issue Mar 23, 2024
@linawolf
[BUGFIX] Make links to special objects prefixable
397e026 
If we have both an anchor like '.. _demo:' and
a confval of the same name we would get duplicate id's and the links to those two elements could not be distinguished. Sphinx solves this by prefixing all confval links with "confval-".

Therefore, I introduce the possibility of prefixing links to distinguished linkable objects.

related phpDocumentor/guides#924

releases: main, 1.0
(cherry picked from commit 3ef4ee08b2049e485d6fb30beb85ee1cbbeb883d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linawolf linawolf

Labels
feature triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brotkrueml @linawolf