Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.4] Add new constants and tokens from the tokenizer #3936

Merged
merged 3 commits into from
Oct 29, 2024
Merged

[PHP 8.4] Add new constants and tokens from the tokenizer #3936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3f17f9
[PHP 8.4] Add new constants and tokens from the tokenizer
driade Oct 27, 2024
3be309b
fix - missing space
driade Oct 29, 2024
8838f72
fix - these lists are ordered
driade Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions appendices/migration84/constants.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,21 @@
</simplelist>
</sect2>

<sect2 xml:id="migration84.constants.tokenizer">
<title>Tokenizer</title>
<simplelist>
<member>
<constant>T_PUBLIC_SET</constant>
</member>
<member>
<constant>T_PROTECTED_SET</constant>
</member>
<member>
<constant>T_PRIVATE_SET</constant>
</member>
</simplelist>
</sect2>
Comment on lines +289 to +302
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is alphabetical, please move it to the correct place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Reordered tokens.xml too.


<sect2 xml:id="migration84.constants.xml">
<title>XML</title>

Expand Down
21 changes: 21 additions & 0 deletions appendices/tokens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,20 +708,41 @@ defined('T_FN') || define('T_FN', 10001);
<link linkend="language.oop5">classes and objects</link>
</entry>
</row>
<row xml:id="constant.t-private-set">
<entry><constant>T_PRIVATE_SET</constant></entry>
<entry>private(set)</entry>
<entry>
property hooks (available as of PHP 8.4.0)
</entry>
</row>
<row xml:id="constant.t-protected">
<entry><constant>T_PROTECTED</constant></entry>
<entry>protected</entry>
<entry>
<link linkend="language.oop5">classes and objects</link>
</entry>
</row>
<row xml:id="constant.t-protected-set">
<entry><constant>T_PROTECTED_SET</constant></entry>
<entry>protected(set)</entry>
<entry>
property hooks (available as of PHP 8.4.0)
</entry>
</row>
<row xml:id="constant.t-public">
<entry><constant>T_PUBLIC</constant></entry>
<entry>public</entry>
<entry>
<link linkend="language.oop5">classes and objects</link>
</entry>
</row>
<row xml:id="constant.t-public-set">
<entry><constant>T_PUBLIC_SET</constant></entry>
<entry>public(set)</entry>
<entry>
property hooks (available as of PHP 8.4.0)
</entry>
</row>
<row xml:id="constant.t-readonly">
<entry><constant>T_READONLY</constant></entry>
<entry>readonly</entry>
Expand Down