[PHP 8.4] Add new constants and tokens from the tokenizer #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwins
approved these changes
Oct 28, 2024
appendices/tokens.xml
Outdated
| <entry><constant>T_PROTECTED_SET</constant></entry> | ||
| <entry>protected(set)</entry> | ||
| <entry> | ||
| property hooks(available as of PHP 8.4.0) |
There was a problem hiding this comment.
Missing space.
Suggested change
| property hooks(available as of PHP 8.4.0) | |
| property hooks (available as of PHP 8.4.0) |
|
Done! |
Girgias
requested changes
Oct 29, 2024
There was a problem hiding this comment.
@iluuu1994 this probably needs to be mentioned in UPGRADING
Comment on lines
+302
to
+315
| <sect2 xml:id="migration84.constants.tokenizer"> | ||
| <title>Tokenizer</title> | ||
| <simplelist> | ||
| <member> | ||
| <constant>T_PUBLIC_SET</constant> | ||
| </member> | ||
| <member> | ||
| <constant>T_PROTECTED_SET</constant> | ||
| </member> | ||
| <member> | ||
| <constant>T_PRIVATE_SET</constant> | ||
| </member> | ||
| </simplelist> | ||
| </sect2> |
There was a problem hiding this comment.
The list is alphabetical, please move it to the correct place.
There was a problem hiding this comment.
Done. Reordered tokens.xml too.
Girgias
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the property hooks page is done, links should be added in tokens.xml