-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) #184
Conversation
Build passed successfully for:
but i don't know why for 7.2 i've got php-cs-fixer sugesstions on files which i didn't touch. |
I think we definitely should update some out-of-date dependencies like Support for |
@mrwogu What about using StorageObject instead? |
Ok, i've renamed from Unfortunately, PHPUnit is also outdated and I had to update it to a new version. |
d6ac9a5
to
0a44efa
Compare
@haphan could you merge this into php-opencloud:php-7.2? |
Great works @mrwogu but I think commits got messed up during rebase. Can you try to rebase it again? |
@haphan done |
@mrwogu Awesome works! 🎸 I've made only minor improvements to the README and Branch |
No description provided.