Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supprt php7.2.2 #4

Closed
kslr opened this issue Feb 28, 2018 · 2 comments
Closed

supprt php7.2.2 #4

kslr opened this issue Feb 28, 2018 · 2 comments

Comments

@kslr
Copy link

kslr commented Feb 28, 2018

php-opencloud/openstack v2.1.4 requires php >=7.0 <7.2 -> your PHP version (7.2.2) does not satisfy that requirement.

Due to new object typehint since PHP 7.2, Object is a reserved keyword thus class -OpenStack\ObjectStore\v1\Models\Object had to be renamed to -OpenStack\ObjectStore\v1\Models\StorageObject. See #184 for details.

php-opencloud/openstack#184

So should a new branch support be established?
Can I submit v2?

@kslr
Copy link
Author

kslr commented Feb 28, 2018

#5 By the way, please update the composer :)

@sausin
Copy link
Owner

sausin commented Feb 28, 2018

@kslr thanks! As mentioned to #5, #3 submitted prior was merged.

@sausin sausin closed this as completed Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants