Fixes memory errors, broken code, bugs etc #214
Conversation
|
Fixes #199 among other issues. |
Fixes memory errors, broken code, bugs etc
|
@mkoppanen I have some trouble with cas_token, seems it isn’t processed https://github.com/mkoppanen/php-memcached/blob/a930b41fa138a55b976c55e21157e57b09355343/php_memcached.c#L1356 |
|
@xjewer, cas parameters has been removed (signature change). It was causing issues with inheritance. |
|
🙈 i found out |
|
package.xml has release notes that contain the note |
|
👌 |
|
@mkoppanen So a user can set
https://github.com/php-memcached-dev/php-memcached/blob/php7/package.xml#L41 |
|
@fadimko there are a ->cas() and ->casMulti() for CAS operations |
|
How can I retrieve them after a |
|
@fadimko, after a get call? You would retrieve them with Memcached::GET_EXTENDED during a get call |
|
@mkoppanen Oh, now I see. I didn't notice this string:
https://github.com/php-memcached-dev/php-memcached/blob/php7/php_memcached.c#L1405 |
|
Thank you |
|
@fadimko, yep. It's not ideal from API perspective but it fixes issues with inheriting the class and overriding get (for example PHPUnit seems to do this) |
|
what about difference between signature and arginfo? https://github.com/php-memcached-dev/php-memcached/blob/php7/php_memcached.c#L1394 if (zend_parse_parameters(ZEND_NUM_ARGS(), "S|f!l", &key, &fci, &fcc, &get_flags) == FAILURE) {
return;
}ZEND_BEGIN_ARG_INFO_EX(arginfo_get, 0, 0, 1)
ZEND_ARG_INFO(0, key)
ZEND_ARG_INFO(0, cache_cb)
ZEND_END_ARG_INFO() |
|
I think missed. Can you open a pr for that? |
|
|
And what about AT LEAST mentioning it on the PHP manual page? One year later and this is not mentioned anywhere! http://php.net/manual/en/memcached.get.php |
|
@letynsoft Editing the manual is a whole separate workflow. Community contributions highly appreciated on this. |
This was introduced in 6837d89494, pull php-memcached-dev#214. I suspect it may have been a left-over from debugging something. The test was later changed in 6837d89 to expect the warning in question, although other similar tests don't encounter such warning currently. It appears no other Memcached methods emit a PHP Warning when they encounter a write read or failure. Instead, they typically turn their return value into boolean false, and provide details via getResultMessage(). The introduction of this warning since php-memcached 3.0 has led to a number of confused consumers (locally php-memcached-dev#260, php-memcached-dev#409, php-memcached-dev#450, and more reports within downstream issue trackers). Closes php-memcached-dev#409.
This was introduced in 6837d89494, pull php-memcached-dev#214. I suspect it may have been a left-over from debugging something. The test was later changed in 6837d89 to expect the warning in question, although other similar tests don't encounter such warning currently. It appears no other Memcached methods emit a PHP Warning when they encounter a write read or failure. Instead, they typically turn their return value into boolean false, and provide details via getResultMessage(). The introduction of this warning since php-memcached 3.0 has led to a number of confused consumers (locally php-memcached-dev#260, php-memcached-dev#409, php-memcached-dev#450, and more reports within downstream issue trackers). Closes php-memcached-dev#409.
This was introduced in 6837d89494, pull php-memcached-dev#214. I suspect it may have been a left-over from debugging something. The test was later changed in 6837d89 to expect the warning in question, although other similar tests don't encounter such warning currently. It appears no other Memcached methods emit a PHP Warning when they encounter a write read or failure. Instead, they typically turn their return value into boolean false, and provide details via getResultMessage(). The introduction of this warning since php-memcached 3.0 has led to a number of confused consumers (locally php-memcached-dev#260, php-memcached-dev#409, php-memcached-dev#450, and more reports within downstream issue trackers). Closes php-memcached-dev#409.
This was introduced in php-memcached-dev@6837d89494, pull php-memcached-dev#214. I suspect it may have been a left-over from debugging something. The test was later changed in 6837d89 to expect the warning in question, although other similar tests don't encounter such warning currently. It appears no other Memcached methods emit a PHP Warning when they encounter a write read or failure. Instead, they typically turn their return value into boolean false, and provide details via getResultMessage(). The introduction of this warning since php-memcached 3.0 has led to a number of confused consumers (locally php-memcached-dev#260, php-memcached-dev#409, php-memcached-dev#450, and more reports within downstream issue trackers). Closes php-memcached-dev#409.
This was introduced in 6837d89494, pull #214. I suspect it may have been a left-over from debugging something. The test was later changed in 6837d89 to expect the warning in question, although other similar tests don't encounter such warning currently. It appears no other Memcached methods emit a PHP Warning when they encounter a write read or failure. Instead, they typically turn their return value into boolean false, and provide details via getResultMessage(). The introduction of this warning since php-memcached 3.0 has led to a number of confused consumers (locally #260, #409, #450, and more reports within downstream issue trackers). Closes #409.
No description provided.