Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature change in PHP7 branch getMulti #229

Closed
EugenMayer opened this issue Mar 15, 2016 · 5 comments
Closed

Signature change in PHP7 branch getMulti #229

EugenMayer opened this issue Mar 15, 2016 · 5 comments
Milestone

Comments

@EugenMayer
Copy link

Seems like the signature changed

Warning: Memcached::getMulti() expects at most 2 parameters, 3 given

code
$results = $mc->getMulti($full_keys, $null, Memcached::GET_PRESERVE_ORDER);

Seems like it was allowed and has not been updated here:

https://github.com/php-memcached-dev/php-memcached/blob/php7/memcached-api.php#L196

But not according to the code, it has been removed (cas_tokens)

https://github.com/php-memcached-dev/php-memcached/blob/php7/php_memcached.c#L3732

Maybe this is related to #214 (comment) ?

@mkoppanen
Copy link
Member

Correct, api.php is not up to date regarding latest changes. PRs are welcome

@EugenMayer
Copy link
Author

Well beside the api.php, this should also be mentioned in the changelogs - since those are breaking changes. You need to consider this, before making this live - this will need actions on all platforms implementing memcache. Is that all by intention - it seems rather ,it slipped through unnoticed

@mkoppanen
Copy link
Member

It is mentioned in the changelog in package.xml. It is by intention as it resolves the issues in #126

@TysonAndre
Copy link
Contributor

#248 seems to be related to this

@sodabrew
Copy link
Contributor

This is documented now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants