Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh-release make task on MacOS #127

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

marcofranssen
Copy link
Member

@marcofranssen marcofranssen commented Jan 26, 2022

Resolves #103

Signed-off-by: Marco Franssen [email protected]

Tested with the v0.6.0 release.

Resolves #103

Signed-off-by: Marco Franssen <[email protected]>
@marcofranssen marcofranssen requested a review from a team as a code owner January 26, 2022 11:10
@marcofranssen marcofranssen enabled auto-merge (rebase) January 26, 2022 11:10
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #127 (12c0461) into main (3c40057) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   77.92%   77.92%           
=======================================
  Files          15       15           
  Lines         607      607           
=======================================
  Hits          473      473           
  Misses         95       95           
  Partials       39       39           
Flag Coverage Δ
unittests 77.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c40057...12c0461. Read the comment docs.

Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I'm unable to test this, I trust you that this works.

@marcofranssen marcofranssen merged commit 58b193c into main Jan 26, 2022
@marcofranssen marcofranssen deleted the fix-gh-release-make-darwin branch January 26, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix make gh-release to work on MacOS
2 participants