Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make gh-release to work on MacOS #103

Closed
marcofranssen opened this issue Dec 14, 2021 · 0 comments · Fixed by #127
Closed

Fix make gh-release to work on MacOS #103

marcofranssen opened this issue Dec 14, 2021 · 0 comments · Fixed by #127
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@marcofranssen
Copy link
Member

On MacOS there is a different version of sed.

By installing gsed and adding an alias in your .bashrc/.zshrc you can have compatibility.

Make however is not picking aliases and still uses the version of sed that ships with MacOS.

We should find another way in the Makefile to use gsed when running on MacOS. e.g. Detect the OS from the makefile and then conditionally use gsed as opposed to sed.
@marcofranssen marcofranssen added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Dec 14, 2021
marcofranssen added a commit that referenced this issue Jan 26, 2022
@marcofranssen
Fix gh-release make task on MacOS
12c0461 
Resolves #103

Signed-off-by: Marco Franssen <[email protected]>
@marcofranssen marcofranssen mentioned this issue Jan 26, 2022
Merged
marcofranssen added a commit that referenced this issue Jan 26, 2022
@marcofranssen
Fix gh-release make task on MacOS
58b193c 
Resolves #103

Signed-off-by: Marco Franssen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix gh-release make task on MacOS philips-labs/slsa-provenance-action
1 participant
@marcofranssen