Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote the overlay code to production-ready #136

Closed
samreid opened this issue Sep 12, 2018 · 4 comments
Closed

Promote the overlay code to production-ready #136

samreid opened this issue Sep 12, 2018 · 4 comments
Assignees
@samreid

Comments

@samreid
Copy link
Member

samreid commented Sep 12, 2018 •
edited
Loading

From #74, we would like to promote the code that shows the ?theory overlay on the slits screen from prototype to production ready.
@samreid samreid self-assigned this Sep 12, 2018
@samreid
Copy link
Member Author

samreid commented Sep 12, 2018

According to #98 (comment) we only have a month and a half until we would like to start the QA dev testing. The sim is not yet feature complete. Should this issue be deferred?

@samreid samreid assigned arouinfar and unassigned samreid Sep 12, 2018
@samreid
Copy link
Member Author

samreid commented Sep 13, 2018

OK to work on this after we start dev testing. Not essential for right away.

@samreid samreid assigned samreid and unassigned arouinfar and samreid Sep 13, 2018
@samreid
Copy link
Member Author

samreid commented Oct 8, 2018

It seems likely I'll have time to work on this while awaiting feedback on other issues, removing deferred label.

@samreid samreid self-assigned this Oct 8, 2018
samreid added a commit that referenced this issue Oct 8, 2018
@samreid
Run theory overlay synchronously, and factored out constants, see #136
6edff0e
@samreid
Copy link
Member Author

samreid commented Oct 8, 2018

Fixed in the preceding commit, closing.

@samreid samreid closed this as completed Oct 8, 2018
@samreid samreid mentioned this issue Nov 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @arouinfar