Skip to content

Commit

Permalink
promote REVIEW comments to issue, #280, #269
Browse files Browse the repository at this point in the history
Signed-off-by: Chris Malley <[email protected]>
  • Loading branch information
pixelzoom committed Dec 19, 2018
1 parent 432e2cb commit d2713a4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions js/common/view/WaveInterferenceSceneIcons.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
// Copyright 2018, University of Colorado Boulder

//REVIEW very odd to have a class for this, especially since the icons are not at all related. Factory pattern would be
// better.
//REVIEW* They are all related in that they have commensurate dimensions, please see the last few lines
//REVIEW* of the constructor. What do you recommend?
/**
* Creates a set of uniformly-sized icons for each of the scenes.
*
Expand Down

0 comments on commit d2713a4

Please sign in to comment.