Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address REVIEW comments #269

Closed
pixelzoom opened this issue Dec 18, 2018 · 5 comments
Closed

address REVIEW comments #269

pixelzoom opened this issue Dec 18, 2018 · 5 comments
Assignees
@pixelzoom
Labels
dev:code-review status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

Related to code review #259.

I'm adding //REVIEW comments for things that don't warrant a GitHub issue. Close this issue when those comments have been addressed and removed.
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Factored out pulse emitter color and renamed properties, see #269
ab383fe
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Update docs, see #269
fc1eff8
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Factor out DEFAULT_FONT_SIZE and made TIME_AND_LENGTH_SCALE_INDICATOR…
18191f2 
…_FONT one step smaller, see #269
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Assert that LATTICE_DIMENSION is odd, see #269
7e6fab6
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Pass in waterScene.lattice.visibleBounds, see #269
0086ee7
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Use 2-point average on intensity sample end points, see #269
174d0f9
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Address minor issues and add REVIEW* comments, see #269
0a07815
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Fix lint error, see #269
efd4825
@samreid
Copy link
Member

samreid commented Dec 19, 2018 •
edited
Loading

From slack conversation:

I would like to have a straightforward protocol (without too much overhead) for you to be able to verify/validate my changes.

For now, I'd like to make //REVIEW* comments where I have addressed a //REVIEW comment. @pixelzoom can search for this string to see where threads require feedback/discussion/verification. Threads that are completed satisfactorily can be deleted.

UPDATE: Likewise, I've begun using //REVIEW^ to indicate REVIEW comments that still need my attention. This will help me keep organized.

samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Address review issues, see #269
1e206e6
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Address review issues, see #269
e2a759e
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Address review issues, see #269
fa24682
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Use arrow functions, see #269
990eac3
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Address REVIEW comments, see #269
1ebe389
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Address REVIEW comments, see #269
dfb4591
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Add ^ to REVIEW comments that need further work, see #269
df6ff93
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Address review comments, see #269
846ccdf
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Factor out CORNER_RADIUS, see #269
4363e7e
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Add docs, see #269
0922695
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Add docs, see #269
f4ac7cb
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Rename ViewType => ViewpointEnum, see #269
f3996c1
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Add docs, see #269
43a35c0
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Move var to WaterDrop and improve documentation, see #269
61b9169
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Update documentation, see #269
2dc5056
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Rename WaveTemporalType=>DisturbanceType, see #269
0d55921
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Fix WaterDrop signature, see #269
c18a1c5
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Update docs, see #269
88bd163
samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Update docs, see #269
f535c37
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
reply to REVIEW comment, #269
1f84f03 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
reply to REVIEW comment, #269
0feec54 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
reply to REVIEW comment, #269
b702dad 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
reply to REVIEW comment, #269
f75e0e9 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
promote REVIEW comments to issue, #281, #269
4129346 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
reply to REVIEW comment, #269
6641677 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
promote REVIEW comments #269 to issue #282
4afe549 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
accept REVIEW comment reply #269
43b49f0 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
accept and clarify REVIEW reply, #269
0810fc8 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
promote REVIEW comments #269 to issue #283
5482042 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
promote REVIEW comments #269 to issue #283
ca2e39b 
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
REVIEW comments #269
ee2e7b4 
Signed-off-by: Chris Malley <[email protected]>
@pixelzoom pixelzoom mentioned this issue Dec 19, 2018
Closed
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
delete REVIEW comment #269 that was promoted to issue #283
c747d02 
Signed-off-by: Chris Malley <[email protected]>
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Dec 19, 2018 •
edited
Loading

@samreid I've reviewed all of your replies to REVIEW comments since yesterday. All remaining REVIEW comments that require your response can be identified by searching for "REVIEW^" (15 occurrences).

samreid added a commit that referenced this issue Dec 20, 2018
@samreid
Address REVIEW comments, see #269
58b768d
samreid added a commit that referenced this issue Dec 20, 2018
@samreid
Factored out SceneRadioButtonGroup, see #269
347d434
samreid added a commit that referenced this issue Dec 20, 2018
@samreid
Updated review comment, see #269
e173cff
samreid added a commit that referenced this issue Dec 20, 2018
@samreid
Address review comments, see #269
698160d
samreid added a commit that referenced this issue Dec 20, 2018
@samreid
Address review comments, see #269
e6e9ea2
samreid added a commit that referenced this issue Dec 20, 2018
@samreid
Add require statement, see #269
5e15fa0
@samreid
Copy link
Member

samreid commented Dec 20, 2018

All //REVIEW comments addressed, please review. Close if all is well.

@samreid samreid assigned pixelzoom and unassigned samreid Dec 20, 2018
samreid added a commit to phetsims/sun that referenced this issue Dec 20, 2018
@samreid
Remove duplicated docs, see phetsims/wave-interference#269
19bb3f4
pixelzoom added a commit that referenced this issue Dec 20, 2018
@pixelzoom
#269 review and remove all REVIEW threads
d179111 
Signed-off-by: Chris Malley <[email protected]>
@pixelzoom
Copy link
Contributor Author

All REVIEW threads have been reviewed and deleted. Our work here is done. Closing.

samreid added a commit to phetsims/scenery-phet that referenced this issue Oct 29, 2022
@samreid
Address minor issues and add REVIEW* comments, see phetsims/wave-inte…
c401cbb 
…rference#269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom