Reward dialog obscures challenge solution

[pixelzoom]

In phetsims/equality-explorer#104, @amanda-phet identified a problem with the use of the reward dialog (RewardDialog). When you reach a certain score, it opens immediately and obscures the challenge solution.

This problem was also discovered in Make A Ten, see phetsims/make-a-ten#284.

Identify whether these are other sims that have this problem.

[amanda-phet]

@phet-steele can you create a QA task (for yourself or someone else) to identify other sims with rewardnode where this issue is relevant?

[pixelzoom]

@phet-steele The common-code implementation (VEGAS/RewardNode) is currently used only in Equality Explorer and the vegas demo application. Make A Ten has its own implementation (which should be replaced with VEGAS/RewardNode, see phetsims/make-a-ten#279). Unknown whether other sims have a similar dialog. If they do, they are not using common code, and an issue should also be created to make them use VEGAS/RewardNode.

[phet-steele]

@amanda-phet identified a problem with the use of the reward dialog (RewardDialog)

(VEGAS/RewardNode) is currently used only in Equality Explorer and the vegas demo application. Make A Ten has its own implementation...

@amanda-phet @pixelzoom what am I looking for? Sims with relevant issues in RewardDialog, or RewardNode? Or both?

[pixelzoom]

You're looking for sims that open a dialog that obscures the challenge solution. They will not use RewardDialog because it is a new component; they will have their own Dialog, or perhaps something that quacks like a Dialog (as in Make A Ten, where a Panel is used). RewardNode (objects falling behind the dialog) is afaik not implicated in this issue.

[phet-steele]

@pixelzoom @amanda-phet I went ahead and looked for both, hopefully I'm correct about most of this. I'm not too happy about the lack of RewardNode usage! 😄

I only looked at published sims, which excludes:

• Build a Fraction
• Estimation (slight chuckle)
• Fractions: Equality
• Fractions Intro
• Fractions: Mixed Numbers

The following sims were also ignored. They have game-like designs, but are vastly different than anything else:

• Function Builder
• Function Builder: Basics
• Unit Rates

Area Builder

RewardNode	RewardDialog	LevelCompletedNode
NO	NO	YES

• No overlap on completion. The reward appears alone after "Next" is pressed on the last challenge:

Area Model Algebra/Multiplication

RewardNode	RewardDialog	LevelCompletedNode
YES	NO	YES

• No overlap on completion. The reward appears alone after "Next" is pressed on the last challenge:

Arithmetic

RewardNode	RewardDialog	LevelCompletedNode
NO	NO	YES

• Questionable overlap. The reward appears about ~1.5 seconds (guesstimate) after the last answer is submitted.

Balancing Act

RewardNode	RewardDialog	LevelCompletedNode
NO	NO	YES

• No overlap on completion. The reward appears alone after "Next" is pressed on the last challenge:

Balancing Chemical Equations

RewardNode	RewardDialog	LevelCompletedNode
YES (but as BCERewardNode)	NO	YES

• No overlap on completion. The reward appears alone after "Next" is pressed on the last challenge:

Build an Atom

RewardNode	RewardDialog	LevelCompletedNode
YES (but as BAARewardNode)	NO	YES

• No overlap on completion. The reward appears alone after "Next" is pressed on the last challenge:

Equality Explorer

RewardNode	RewardDialog	LevelCompletedNode
YES (but as EqualityExplorerRewardNode)	YES	NO

• Purposefully ignored changes from Reward dialog obscures challenge solution equality-explorer#104. Questionable overlap. The reward appears immediately after the last answer is "reached" (subtly different than "submitted"):

Expression Exchange

RewardNode	RewardDialog	LevelCompletedNode
YES (but as EERewardNode)	NO	NO

• Important: Uses a completely custom Dialog: AllLevelsCompletedDialog
• Non-problematic overlap. The reward appears immediately after the last answer is "reached" (subtly different than "submitted"):

Fraction Matcher

RewardNode	RewardDialog	LevelCompletedNode
YES	NO	YES

• Non-problematic overlap. The reward appears after "OK" is pressed on the last challenge:

Graphing Lines/Graphing Slope-Intercept

RewardNode	RewardDialog	LevelCompletedNode
YES (but as GLRewardNode)	NO	YES (but as ResultsNode)

• No overlap on completion. The reward appears alone after "Next" is pressed on the last challenge:

Make a Ten

RewardNode	RewardDialog	LevelCompletedNode
YES (but as MakeATenRewardNode)	NO	NO

• Important: Uses a completely custom Dialog: RewardPanel
• Questionable overlap. The reward appears immediately after the last answer is "reached" (subtly different than "submitted"):

Reactants, Products and Leftovers

RewardNode	RewardDialog	LevelCompletedNode
YES (but as RPALRewardNode)	NO	YES (but as ResultsNode)

• No overlap on completion. The reward appears alone after "Next" is pressed on the last challenge:

[pixelzoom]

To summarize for @amanda-phet...

There is "questionable" overlap in Equality Explorer (phetsims/equality-explorer#104), Make A Ten (phetsims/make-a-ten#284) and Arithmetic (phetsims/arithmetic#183).

It is @amanda-phet's call on whether/how to address this.

[pixelzoom]

This needs to be addressed on a per-sim basis (no common-code solution), and each sim that has this problem has an associated issue. So closing this issue.