Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused option ValuePanel.titleMaxWidth #213

Closed
zepumph opened this issue Jul 15, 2019 · 1 comment
Closed

Unused option ValuePanel.titleMaxWidth #213

zepumph opened this issue Jul 15, 2019 · 1 comment
Assignees
@pixelzoom

Comments

@zepumph
Copy link
Member

zepumph commented Jul 15, 2019

While working on phetsims/gravity-force-lab#165 I noticed, via a global search of titleMaxWidth, that this option doesn't appear to be used. @pixelzoom sorry if I just don't understand, but over to you to fix or clarify.
@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 15, 2019 •
edited
Loading

I inherited this sim from another developer, and commit history for ValuePanel indicates that it was "a rewrite of scale and timer display". So I'm guessing that titleMaxWidth is a vestigial option from some code that I inherited and rewrote. The title's maxWidth appears to be properly computed, and I see no titleMaxWidth option in the superclass (Panel), so I'll go ahead and remove it.

pixelzoom added a commit that referenced this issue Jul 15, 2019
@pixelzoom
delete vestigial option titleMaxWidth, #213
7d4d747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph