Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This sim fails stringTest=long #165

Closed
zepumph opened this issue Jul 2, 2019 · 2 comments
Closed

This sim fails stringTest=long #165

zepumph opened this issue Jul 2, 2019 · 2 comments
Assignees
@zepumph
Labels
dev:code-review

Comments

@zepumph
Copy link
Member

zepumph commented Jul 2, 2019

image
@zepumph zepumph self-assigned this Jul 2, 2019
@zepumph
Copy link
Member Author

zepumph commented Jul 2, 2019

Note this also is the case with CL, but not in the published version,
image

@zepumph zepumph mentioned this issue Jul 15, 2019
Closed
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Jul 15, 2019
@zepumph
use merge to simplify options extending, phetsims/gravity-force-lab#165
1d9a8ef
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Jul 15, 2019
@zepumph
fix nested options bug by renaming title options, phetsims/gravity-fo…
964039a 
…rce-lab#165
@zepumph
Copy link
Member Author

zepumph commented Jul 15, 2019

Looks like this is a bug that came out of phetsims/scenery-phet#451. There were two title specific options in ISLCControlPanel that weren't renamed when converted to use nested options for control panel. While in there I converted the file to use merge, and that cleaned some stuff up.

@zepumph zepumph closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph