Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Graphing Lines 1.2.0-dev.2 #825

Closed
3 tasks done
pixelzoom opened this issue Apr 25, 2017 · 5 comments
Closed
3 tasks done

Dev test: Graphing Lines 1.2.0-dev.2 #825

pixelzoom opened this issue Apr 25, 2017 · 5 comments
Assignees
Labels

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 25, 2017

Previous dev test (1.2.0-dev.1) is #816. See that issue for pointers to query parameters, terminology, etc.

Dev test:
http://www.colorado.edu/physics/phet/dev/html/graphing-lines/1.2.0-dev.2/graphing-lines_en.html

iFrame test:
http://www.colorado.edu/physics/phet/dev/html/graphing-lines/1.2.0-dev.2/graphing-lines_en-iframe.html

GitHub issues to regression tests:

In addition to the specific issues above, the fix for phetsims/graphing-lines#78 (memory leak) touched a lot of code. It's not necessary to re-verify the memory test. But please give the entire sim a close look on at least 1 platform to make sure there was no collateral damage.

Please mention this issue in any GitHub issues that you create.

Assigned to @phet-steele, please work out prioritization with @ariel-phet.

@phet-steele
Copy link

@pixelzoom this is completed. Sim is very solid at this point.

@phet-steele phet-steele removed their assignment May 15, 2017
@pixelzoom
Copy link
Contributor Author

Thanks @phet-steele and team.

@pixelzoom
Copy link
Contributor Author

Since this dev test went well (no issues), I was planning to use the 1.2.0-dev.2 shas for 1.2.0-rc.1. But then I discovered that @jessegreenberg published 1.2.0-dev.3, and I have no idea if it addresses anything relevant to this sim. So RC testing is blocked until I can find out what's up with 1.2.0-dev.3.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented May 16, 2017

According to @jessegreenberg, Graphing Lines 1.2.0-dev.3 was used to test phetsims/joist#140 (a11y heartbeat fix), not relevant to production sims yet. So I can proceed with the shas from 1.2.0-dev.2.

@pixelzoom
Copy link
Contributor Author

RC test task #843 created. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants