Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Graphing Lines 1.2.0-dev.1 #816

Closed
pixelzoom opened this issue Apr 11, 2017 · 6 comments
Closed

Dev test: Graphing Lines 1.2.0-dev.1 #816

pixelzoom opened this issue Apr 11, 2017 · 6 comments
Assignees
Labels

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 11, 2017

Dev test:
http://www.colorado.edu/physics/phet/dev/html/graphing-lines/1.2.0-dev.1/graphing-lines_en.html

iFrame test:
http://www.colorado.edu/physics/phet/dev/html/graphing-lines/1.2.0-dev.1/graphing-lines_en-iframe.html

Major changes were made to the Line Game screen in order to support its reuse in the Graphing Slope-Intercept sim. So we're mainly interested in testing the Line Game screen. All of the changes should be platform agnostic, but I've been testing mainly on Chrome, Safari and Safari mobile.

There have been no changes to the first 3 screens, but give them a quick test in case any common-code changes have broken something.

The 3 issues that were fixed in Graphing Slope-Intercept dev testing should also be fixed here. For a list of those issues, see #812.

Sim-specific query parameters are in GLQueryParameters.js.

Please mention this issue in any GitHub issues that you create.

@pixelzoom
Copy link
Contributor Author

Note to self: This dev version was created with shas from graphing-slope-intercept 1.0.0-rc.1, with the following changes: graphing-lines master, chipper master

@pixelzoom
Copy link
Contributor Author

@ariel-phet please prioritize and assign.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 18, 2017

@phet-steele Since this dev version was built from shas from graphing-slope-intercept 1.0.0-rc.1 (see #816 (comment)), it almost certainly has the web audio problem phetsims/vibe#30. Tracking that in phetsims/graphing-lines#76.

@pixelzoom
Copy link
Contributor Author

Next dev (RC?) version will be built with shas from graphing-slope-intercept 1.0.0-rc.2.

@pixelzoom
Copy link
Contributor Author

Due to significant code changes required to address phetsims/graphing-lines#78 (memory leak in Graphing Lines), @phet-steele and I agreed that this would be a good place to stop this dev test task. And we should do another dev test of Graphing Lines prior to starting on the next RC test for Graphing Slope-Intercept.

Leaving this issue assign to me so that I can identify issues that require regression testing in the next task.

@pixelzoom
Copy link
Contributor Author

Dev testing continues in #825.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants